add oauth verify api #291
Merged
add oauth verify api #291
+98
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xingoxu
suggested changes
Aug 6, 2021
lib/client.ts
Outdated
| @@ -679,6 +679,24 @@ export class OAuth { | |||
| return this.http.postForm(`${OAUTH_BASE_PREFIX}/revoke`, { access_token }); | |||
| } | |||
|
|
|||
| public verifyAccessToken(access_token: string): Promise<{}> { | |||
There was a problem hiding this comment.
I just referenced revokeAccesstoken API method.
What do you want to return value?
Do it expect expires_in?
lib/client.ts
Outdated
| client_id: string, | ||
| nonce: string = undefined, | ||
| user_id: string = undefined, | ||
| ): Promise<{}> { |
| #### `revokeAccessToken(access_token: string): Promise<{}>` | ||
|
|
||
| It corresponds to the [Revoke channel access token](https://developers.line.biz/en/reference/messaging-api/#revoke-channel-access-token) API. | ||
| It corresponds to the [Revoke channel access token](https://developers.line.biz/en/reference/line-login/#revoke-access-token) API. |
|
I think we should follow the original API since we are building public sdk
so we need to provide the response type as the document.
…On Fri, Aug 6, 2021 at 15:05 koichi uchinishi ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In lib/client.ts
<#291 (comment)>
:
> @@ -679,6 +679,24 @@ export class OAuth {
return this.http.postForm(`${OAUTH_BASE_PREFIX}/revoke`, { access_token });
}
+ public verifyAccessToken(access_token: string): Promise<{}> {
I referenced revokeAccesstoken API method.
What do you want to return value?
Do it expect expires_in?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#291 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACBFVO35XFWDXOUAECZKEXLT3N3SVANCNFSM5A6KKXXA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
4geru
force-pushed
the
add-oauth-verify-api
branch
from
af4703e
to
16cd529
Compare
xingoxu
reviewed
Aug 10, 2021
lib/client.ts
Outdated
| public verifyIdToken( | ||
| id_token: string, | ||
| client_id: string, | ||
| nonce: string = undefined, |
There was a problem hiding this comment.
@4geru sann
Would you please change it to
nonce?: string,
user_id?: string
16cd529
to
67076ce
Compare
|
@xingoxu Sorry for the delay. nonce and user_id are now supported. Please review again. |
xingoxu
suggested changes
Oct 29, 2021
docs/api-reference/oauth.md
Outdated
| @@ -21,7 +22,13 @@ class OAuth { | |||
| client_id: string, | |||
| client_secret: string, | |||
| access_token: string, | |||
| ): Promise<{}> | |||
| ): Promise<Types.VerifyAccessToken> | |||
There was a problem hiding this comment.
Types.VerifyAccessToken maybe wrong places?
docs/api-reference/oauth.md
Outdated
| @@ -66,9 +73,19 @@ It corresponds to the [Issue channel access token](https://developers.line.biz/e | |||
| const { access_token, expires_in, token_type } = await oauth.issueAccessToken("client_id", "client_secret"); | |||
| ``` | |||
|
|
|||
|
|
|||
| #### `verifyAccessToken(access_token: string): Promise<{}>` | |||
There was a problem hiding this comment.
Suggested change
| #### `verifyAccessToken(access_token: string): Promise<{}>` | |
| #### `verifyAccessToken(access_token: string): Promise<Types.VerifyAccessToken>` |
4geru
force-pushed
the
add-oauth-verify-api
branch
from
67076ce
to
800acf6
Compare
|
Thank you very much! |
|
@xingoxu thank you for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add verify api.
https://developers.line.biz/en/reference/line-login/#oauth
i'd like to check verify liff access token, and revoke.