Add Webhook delivery completion event #458
Conversation
|
|
lib/types.ts
Outdated
| /** | ||
| * Webhook event ID, an ID that uniquely identifies a Webhook event, in the form of a ULID string. | ||
| */ | ||
| webhookEventId: string; | ||
| /** | ||
| * Whether the webhook event is a resubmitted one or not | ||
| */ | ||
| deliveryContext: DeliveryContext; |
There was a problem hiding this comment.
It is added in common-properties.
https://developers.line.biz/en/reference/messaging-api/#common-properties
test/middleware.spec.ts
Outdated
| timestamp: 0, | ||
| mode: "active", | ||
| type: "message", | ||
| }; | ||
| const webhookSignature = { | ||
| "X-Line-Signature": "GzU7H3qOXDzDD6cNcS/9otLzlLFxnYYriz62rNu5BDE=", | ||
| "X-Line-Signature": "Ey7AjSuSI2GfTDQHICAiRLLJ+GSMseISNYaQ6qXSjrU=", |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
There is another PR (#340) addressing the same issue from last year. I also worked on resolving this issue at https://github.com/Gasol/line-bot-sdk-nodejs/tree/add-missing-properties-in-event-base Seriously, It's important for LINE to be more proactive in maintaining their open source projects. |
|
@nsuzuki7713 thank you for submitting this change! Could you resolve conflict please? |
|
Thank you for your review! I've resolved the conflict in the code. |
Webhook can receive delivery completion events.
However, no type definition is currently provided.
Therefore, I have added a type definition for delivery completion event in this pull request.