Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MSW instead of nock. #568

Merged
merged 14 commits into from
Nov 2, 2023
Merged

Use MSW instead of nock. #568

merged 14 commits into from
Nov 2, 2023

Conversation

tokuhirom
Copy link
Member

nock doesn't support window.fetch. As a result, #541 failes.
So, it's time to use MSW!

@tokuhirom tokuhirom enabled auto-merge (squash) November 2, 2023 01:58
Yang-33
Yang-33 approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@Yang-33 Yang-33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉🎊🎊🎊

@tokuhirom tokuhirom merged commit 39a5eb3 into line:master Nov 2, 2023
3 checks passed
@tokuhirom tokuhirom deleted the msw branch November 2, 2023 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yang-33 Yang-33 Yang-33 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tokuhirom @Yang-33