Support CJS again #797
Merged
Support CJS again #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yang-33
commented
Apr 1, 2024
| @@ -18,6 +17,6 @@ | |||
| "@types/express": "^4.17.17", | |||
| "@types/node": "^20.6.3", | |||
| "rimraf": "^5.0.1", | |||
| "typescript": "^5.2.2" | |||
| "typescript": "^5.4.3" | |||
There was a problem hiding this comment.
typescript version < 5.3 can't compile this project now. Let me investigate it ...
tokuhirom
approved these changes
Apr 1, 2024
Yang-33
force-pushed
the
03-add-esm-test-project
branch
from
403e115
to
5a813e3
Compare
Yang-33
force-pushed
the
04-support-cjs-again
branch
from
94043db
to
3ddcc78
Compare
|
conflict is resolved by rebasing. Diff: https://github.com/line/line-bot-sdk-nodejs/compare/94043db3a5bdca380c7f2e3a8d497f9c8f399fad..3ddcc78801093138058379d767f8b072604c769d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will also support CJS to make it a dual package. It seems that for Typescript, it needs to be version 5.3 or higher.
Additionally, I have introduced two validators for the dual package.