Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using doc branch to use github pages #868

Merged

Conversation

Yang-33
Copy link
Contributor

@Yang-33 Yang-33 commented Jun 1, 2024

gh-pages branch for documentation is no longer necessary. By using GitHub Actions, you can utilize GitHub Pages directly.

This change supports that. Additionally, this change has made sure not to update the documentation until the upload to npm is complete. This is to prevent confusion among users if the documentation is updated but package is not updated.

TODO: Modify settings in https://github.com/line/line-bot-sdk-nodejs/settings/pages after this change is merged

ref: https://vitepress.dev/guide/deploy#github-pages

Resolve #521

@Yang-33
Copy link
Contributor Author

Yang-33 commented Jun 1, 2024

Please ignore test failure (Node.js 20). I'll fix this somehow later in other pull request.

@Yang-33 Yang-33 requested a review from tokuhirom June 1, 2024 14:55
@Yang-33 Yang-33 enabled auto-merge (squash) June 1, 2024 15:04
Copy link
Member

@tokuhirom tokuhirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

@Yang-33 Yang-33 disabled auto-merge June 4, 2024 06:08
@Yang-33 Yang-33 merged commit f324445 into line:master Jun 4, 2024
2 of 3 checks passed
@Yang-33 Yang-33 deleted the stop-using-gh-pages-branch-to-use-github-pages branch June 4, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy docs by github actions
2 participants