Skip to content

New field 'destination' in Webhook request #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2019
Merged

Conversation

okue
Copy link
Member

@okue okue commented Jun 17, 2019

#131

  1. Add a new field destination in Webhook request.
  2. Add tests
  3. Update README
    • Add an explanation about WebhookHandler.add

@okue okue requested a review from be-hase June 17, 2019 15:50
Copy link
Member

@be-hase be-hase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -977,6 +978,7 @@ Test by using tox. We test against the following versions.
- 3.4
- 3.5
- 3.6
- 3.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@okue
Copy link
Member Author

okue commented Jun 18, 2019

How about inserting 'WebhookPayload' into this?
https://github.com/line/line-bot-sdk-python/blob/master/linebot/__init__.py#L30-L34

Done.

@okue okue merged commit 4d1d425 into master Jun 18, 2019
@okue okue deleted the issue-131-destination branch June 18, 2019 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants