Skip to content

Implement stickerResourceType property #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 10, 2019
Merged

Implement stickerResourceType property #229

merged 3 commits into from
Dec 10, 2019

Conversation

@clsung
Copy link
Contributor

@clsung clsung commented Dec 9, 2019

implments #228

@okue okue requested review from cryeo and okue December 9, 2019 09:07
@okue okue mentioned this pull request Dec 9, 2019
Merged
@okue
Copy link
Member

okue commented Dec 9, 2019

Thanks for your PR.

Would you merge master into your branch? (I modified the pydocstring which causes the CI to fail)

@clsung clsung force-pushed the sticker_resource_type branch from e374306 to 66f61b4 Compare December 9, 2019 12:09
@clsung
Copy link
Contributor Author

clsung commented Dec 9, 2019

Thanks for your PR.

Would you merge master into your branch? (I modified the pydocstring which causes the CI to fail)

rebased, thanks for notification

@okue
Copy link
Member

okue commented Dec 10, 2019

Would you please add an item sticker_resource_type to the following place?
https://github.com/line/line-bot-sdk-python/blame/b93d92954a66a77a057f3cc60098d1f6740998ee/README.rst#L1059-L1063

cryeo
cryeo reviewed Dec 10, 2019
View reviewed changes
@clsung
Copy link
Contributor Author

clsung commented Dec 10, 2019

Would you please add an item sticker_resource_type to the following place?
https://github.com/line/line-bot-sdk-python/blame/b93d92954a66a77a057f3cc60098d1f6740998ee/README.rst#L1059-L1063

Added, thanks.

okue
okue reviewed Dec 10, 2019
View reviewed changes
okue
okue approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@okue okue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@okue okue merged commit b51ffbb into line:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@cryeo cryeo cryeo approved these changes

@okue okue okue approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@clsung @okue @cryeo