Skip to content

Conversation

@clsung
Copy link
Contributor

@clsung clsung commented Feb 12, 2020

@clsung
Copy link
Contributor Author

clsung commented Feb 12, 2020

Some comments will be updated when official English translation is released.

This section will be translated into English soon.

Copy link
Member

@cryeo cryeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!
I just leaved some comments, please check.
(and please update docs after English documentation is released)

@tkgauri tkgauri requested a review from okue February 21, 2020 03:18
@okue
Copy link
Member

okue commented Feb 23, 2020

Now, you can update!

Some comments will be updated when official English translation is released.

This section will be translated into English soon.

Copy link
Member

@okue okue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM

@clsung clsung requested a review from cryeo February 24, 2020 12:58
Copy link
Member

@okue okue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits #241 (comment)

@okue okue requested a review from cryeo February 25, 2020 13:15
@okue
Copy link
Member

okue commented Feb 26, 2020

Thanks @clsung!

@okue okue merged commit 91300c1 into line:master Feb 26, 2020
@clsung clsung deleted the narrowcast branch February 29, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants