Skip to content

Fix hero block in bubble container to accept box component #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
okue merged 1 commit into from
Jun 26, 2020
Merged

Fix hero block in bubble container to accept box component #274

okue merged 1 commit into from
Jun 26, 2020

Conversation

@cryeo
Copy link
Member

@cryeo cryeo commented Jun 18, 2020

Resolve #273

@okue okue added the bug label Jun 26, 2020
okue
okue approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@okue okue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@okue okue merged commit 2ff8fe1 into line:master Jun 26, 2020
@okue okue added this to the 1.17.0 milestone Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@okue okue okue approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

1.17.0

Development

Successfully merging this pull request may close these issues.

Can't send FlexMessage with Hero block

2 participants

@cryeo @okue