Add validating message objects APIs #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
CI failure will be fixed in #410 |
Contributor
Author
|
@louis70109 could you take a look please? |
Member
@Yang-33 I leave a few messages in review, please check~ |
Contributor
Author
|
@louis70109 probably you forgot submitting review comments. Could you check please? I can't find any messages... |
louis70109
reviewed
Jan 7, 2023
Comment on lines
+398
to
+399
| return ValidatePushMessageObjectsResponse( | ||
| request_id=response.headers.get('X-Line-Request-Id')) |
Member
@Yang-33 oh so sorry, thanks notification! |
louis70109
approved these changes
Feb 10, 2023
Member
louis70109
left a comment
louis70109
left a comment
There was a problem hiding this comment.
LGTM. Big thanks to @Yang-33 😍
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #408