Skip to content

Conversation

@Yang-33
Copy link
Contributor

@Yang-33 Yang-33 commented Mar 13, 2023

Most line-bot SDKs allow developers to receive undefined events in their own applications. However, this project only logs a warning message developers can't control, and application can't receive events if it uses WebhookHandler. This pull request suppresses the warn log, and newly defines unknown events so that application can receive them and response to LINE users.

@Yang-33 Yang-33 marked this pull request as ready for review March 13, 2023 01:33
Copy link
Contributor

@tokuhirom tokuhirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yang-33 Yang-33 merged commit 3efd85d into line:master Mar 13, 2023
@Yang-33 Yang-33 deleted the undefined-event branch March 13, 2023 02:00
@Yang-33 Yang-33 mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants