Use OpenAPI generator #432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokuhirom
reviewed
Jun 1, 2023
| steps: | ||
| - uses: actions/checkout@v3 | ||
| with: | ||
| submodules: true |
Contributor
There was a problem hiding this comment.
Note: Managing openapi repo as a submodule
| strategy: | ||
| matrix: | ||
| python-version: ['3.7', '3.8', '3.9', '3.10'] | ||
| python-version: ['3.7', '3.8', '3.9', '3.10', '3.11'] |
Yang-33
force-pushed
the
use-openapi-generator
branch
from
3e72a68 to
ee5eefb
Compare
Contributor
|
@louis70109 could you review this? |
Member
|
@tokuhirom ok, let me check~ |
louis70109
approved these changes
Jun 29, 2023
Contributor
Author
|
Thank you for reviewing this change, @tokuhirom @louis70109 ! |
This was referenced Jun 29, 2023
Yang-33
added a commit
to Yang-33/line-bot-sdk-python
that referenced
this pull request
Jun 30, 2023
This reverts commit fe859ad.
Yang-33
added a commit
to Yang-33/line-bot-sdk-python
that referenced
this pull request
Jun 30, 2023
This reverts commit fe859ad.
Yang-33
added a commit
that referenced
this pull request
Jun 30, 2023
* REVERT-3 Revert "chore(deps): update dependency org.apache.maven.plugins:maven-surefire-plugin to v3 (#451)" This reverts commit a1203b9. * REVERT-3 Revert "chore(deps): update dependency org.apache.maven.plugins:maven-jar-plugin to v3 (#450)" This reverts commit e205a65. * REVERT-3 Revert "fix(deps): update dependency org.openapitools:openapi-generator to v6.6.0 (#449)" This reverts commit e3a1cae. * REVERT-3 Revert "fix(deps): update dependency ch.qos.logback:logback-classic to v1.4.8 (#446)" This reverts commit bc25f75. * REVERT-3 Revert "chore(deps): update dependency org.codehaus.mojo:build-helper-maven-plugin to v3.4.0 (#445)" This reverts commit 822f400. * REVERT-3 Revert "chore(deps): update dependency org.apache.maven.plugins:maven-surefire-plugin to v2.22.2 (#443)" This reverts commit 2b8d95e. * REVERT-3 Revert "chore(deps): update dependency org.apache.maven.plugins:maven-jar-plugin to v2.6 (#442)" This reverts commit c443a78. * REVERT-3 Revert "Modify README.rst to pass validation (#441)" This reverts commit 5e4078e. * REVERT-3 Revert "chore(deps): update dependency org.apache.maven.plugins:maven-enforcer-plugin to v3.3.0 (#440)" This reverts commit 1a4f0bf. * REVERT-3 Revert "chore(deps): update dependency org.apache.maven.plugins:maven-compiler-plugin to v3.11.0 (#439)" This reverts commit 89e00a7. * REVERT-3 Revert "Use OpenAPI generator (#432)" This reverts commit fe859ad. * REVERT-3 2.4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces all clients and models in line-bot-sdk-python with new ones generated by OpenApi generator.
PythonNextgenClientCodegen.javain https://github.com/OpenAPITools/openapi-generator. This pull request modifies it to customizediscriminator's behavior.There are some remaining tasks, but it's sufficient to replace because we easily update sdk more quickly than before, thanks to line-openapi and open api generator.
resolve #431