Modify http status code as response for manage-audience #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NODEJSYou can check generated code in nodejs |
GOYou can check generated code in go |
PYTHONYou can check generated code in python |
JAVAYou can check generated code in java |
PHPYou can check generated code in php |
habara-k
approved these changes
Mar 10, 2025
|
According to the code diff, the SDK code for PHP and PYTHON will need to be modified. I will release a patch version for these today. |
This was referenced Mar 10, 2025
Yang-33
pushed a commit
to line/line-bot-sdk-python
that referenced
this pull request
Mar 10, 2025
line/line-openapi#87 This change modifies the HTTP status code for the following audience group-related endpoints, as they were incorrect. Some http status codes are wrong. They should be 202, not 200. 1. `POST /v2/bot/audienceGroup/upload` (`createAudienceGroup`) 2. `PUT /v2/bot/audienceGroup/upload` (`addAudienceToAudienceGroup`) 3. `POST /v2/bot/audienceGroup/upload/byFile` (`createAudienceForUploadingUserIds`) 4. `POST /v2/bot/audienceGroup/click` (`createClickBasedAudienceGroup`) 5. `POST /v2/bot/audienceGroup/imp` (`createImpBasedAudienceGroup`) You can also check if this change is correct by reading https://developers.line.biz/en/reference/messaging-api/#manage-audience-group. NOTE: This change is not a modification of the messaging API itself. It is simply a correction of an error in the YAML description. Co-authored-by: github-actions <github-actions@github.com>
Yang-33
pushed a commit
to line/line-bot-sdk-php
that referenced
this pull request
Mar 10, 2025
line/line-openapi#87 This change modifies the HTTP status code for the following audience group-related endpoints, as they were incorrect. Some http status codes are wrong. They should be 202, not 200. 1. `POST /v2/bot/audienceGroup/upload` (`createAudienceGroup`) 2. `PUT /v2/bot/audienceGroup/upload` (`addAudienceToAudienceGroup`) 3. `POST /v2/bot/audienceGroup/upload/byFile` (`createAudienceForUploadingUserIds`) 4. `POST /v2/bot/audienceGroup/click` (`createClickBasedAudienceGroup`) 5. `POST /v2/bot/audienceGroup/imp` (`createImpBasedAudienceGroup`) You can also check if this change is correct by reading https://developers.line.biz/en/reference/messaging-api/#manage-audience-group. NOTE: This change is not a modification of the messaging API itself. It is simply a correction of an error in the YAML description. --------- Co-authored-by: github-actions <github-actions@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the HTTP status code for the following audience group-related endpoints, as they were incorrect.
Some http status codes are wrong. They should be 202, not 200.
POST /v2/bot/audienceGroup/upload(createAudienceGroup)PUT /v2/bot/audienceGroup/upload(addAudienceToAudienceGroup)POST /v2/bot/audienceGroup/upload/byFile(createAudienceForUploadingUserIds)POST /v2/bot/audienceGroup/click(createClickBasedAudienceGroup)POST /v2/bot/audienceGroup/imp(createImpBasedAudienceGroup)You can also check if this change is correct by reading https://developers.line.biz/en/reference/messaging-api/#manage-audience-group.
NOTE: This change is not a modification of the messaging API itself. It is simply a correction of an error in the YAML description.