Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issues #55

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Fix build issues #55

merged 3 commits into from
Aug 21, 2023

Conversation

onevcat
Copy link
Member

@onevcat onevcat commented Jul 24, 2023

This PR:

  1. Upgrade the min version from 19 to 21. So we can get rid of the multiple DEX issue completely. Since the LINE SDK native for Android will increase the min SDK version very soon, it does not make sense to continue support Android 4.4 for this repo now.
  2. Removes android.enableJetifier and android.enableR8 in demo gradle property file. They are not compatible in older Unity versions and the later ones. So I removed them. The users should be asked to keep their own template files and only adding the necessary ones to the gradle files and properties. I will later try to upgrade the documentation to make this clearer.
  3. I have to add the androidx.lifecycle:lifecycle-viewmodel-ktx to the build.gradle, unless it complains about a duplicated class as I commented in fix: make it able to build with 2020.3.48f1 (b805b124c6b7) #54. I found this solution from this link, but not sure what is it. I need some help on this. @tsairene @plateaukao Any idea or comment? Is there a better way?

@onevcat onevcat requested review from tsairene and plateaukao July 24, 2023 06:44
@tsairene
Copy link
Contributor

tsairene commented Jul 24, 2023

actually, I added androidx.lifecycle:lifecycle-viewmodel-ktx in previous PR#53 as well to be able to compile on 2022 but it doesn't work on my 2020. not sure why...

@onevcat
Copy link
Member Author

onevcat commented Jul 25, 2023

actually, I added androidx.lifecycle:lifecycle-viewmodel-ktx in previous PRhttps://github.com//pull/53 as well to be able to compile on 2022 but it doesn't work on my 2020. not sure why...

Do you still remember what was the error?

I found it was quite hard and too tricky to continue the compile on 2020.3.0, since it was using a quite legacy Gradle. However, starting from 2020.3.15 Unity uses a newer version and things go better.

@tsairene
Copy link
Contributor

I am trying to checkout this PR locally and install 2020.3.15 to build. Will get back to you later

@onevcat
Copy link
Member Author

onevcat commented Aug 7, 2023

@tsairene Hi, is there any news from your last comment?

@tsairene
Copy link
Contributor

@onevcat
Finally, get it built successfully after some environment clean up (tried clear all cache, remove output folder, re-install unity and so on...) I think it's good to merge now :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants