-
Notifications
You must be signed in to change notification settings - Fork 149
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[BUGFIX] Refactor rule validation to take into account labels and ann…
…otations #144 * Move Formset fields to forms module to better group code * Factor out formset template for consistency * Validate labels and annotations django side, then try rendering. This requires knowing how cached_properly is used so that we can validate Django side, and then validate with `promtool`, before actually saving
- Loading branch information
Showing
4 changed files
with
153 additions
and
123 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
{{ formset.management_form }} | ||
<table v-pre class="table"> | ||
<tr> | ||
<th>Name</th> | ||
<th>Value</th> | ||
<th>Delete?</th> | ||
</tr> | ||
{% for row in formset %} | ||
<tr> | ||
<td>{{ row.id }} {{ row.name }}</td> | ||
<td>{{ row.value }}</td> | ||
<td>{{ row.DELETE }}</td> | ||
</tr> | ||
{% for k,v in row.errors.items %} | ||
<tr> | ||
<td colspan="3">{{v}}</td> | ||
</tr> | ||
{% endfor %} | ||
{% endfor %} | ||
</table> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters