Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding exporter defaults from admin gui #114

Merged
merged 9 commits into from
Nov 29, 2018

Conversation

kfdm
Copy link
Collaborator

@kfdm kfdm commented Nov 28, 2018

  • Migrate from using a settings file to register default exporters to managing it via the django admin to ease management tasks.
  • Provide a register-exporter CLI subcommand for use from configuration management
  • Rename register to register-server to distinguish commands

@kfdm kfdm requested a review from m-tkg November 28, 2018 08:52
@codecov-io
Copy link

codecov-io commented Nov 28, 2018

Codecov Report

Merging #114 into master will decrease coverage by 0.05%.
The diff coverage is 31.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
- Coverage      45%   44.94%   -0.06%     
==========================================
  Files          36       37       +1     
  Lines        2324     2336      +12     
==========================================
+ Hits         1046     1050       +4     
- Misses       1278     1286       +8
Impacted Files Coverage Δ
promgen/views.py 43.85% <ø> (+0.08%) ⬆️
promgen/models.py 25.29% <0%> (-0.53%) ⬇️
promgen/admin.py 0% <0%> (ø) ⬆️
promgen/migrations/0006_exporter_options.py 100% <100%> (ø)
promgen/context_processors.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1004c4e...35a454d. Read the comment docs.

@m-tkg
Copy link

m-tkg commented Nov 28, 2018

I found Makefile contains some tabs after .PHONY.

@kfdm kfdm merged commit 06dbcf9 into line:master Nov 29, 2018
@kfdm kfdm deleted the exporter-defaults branch November 29, 2018 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants