Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate URL field for notifications #121

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Conversation

kfdm
Copy link
Collaborator

@kfdm kfdm commented Jan 16, 2019

No description provided.

@kfdm kfdm requested a review from m-tkg January 16, 2019 06:19
@codecov-io
Copy link

Codecov Report

Merging #121 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   44.77%   44.77%           
=======================================
  Files          37       37           
  Lines        2372     2372           
=======================================
  Hits         1062     1062           
  Misses       1310     1310
Impacted Files Coverage Δ
promgen/notification/webhook.py 100% <100%> (ø) ⬆️
promgen/notification/slack.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f20bc1b...b5dbd95. Read the comment docs.

@kfdm kfdm merged commit 6d2f3c5 into line:master Jan 23, 2019
@kfdm kfdm deleted the validate-notifier-url branch January 23, 2019 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants