Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a user subscribes, ensure they have a default notifier configured #122

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

kfdm
Copy link
Collaborator

@kfdm kfdm commented Jan 23, 2019

This should reduce confusion if a user subscribes to a project/service but does not already have notifications subscribe. It will default to using owner.email to create a notification or print a warning if it does not exist

@kfdm kfdm requested a review from m-tkg January 23, 2019 07:28
@codecov-io
Copy link

Codecov Report

Merging #122 into master will decrease coverage by 0.26%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #122      +/-   ##
=========================================
- Coverage   44.77%   44.5%   -0.27%     
=========================================
  Files          37      37              
  Lines        2372    2386      +14     
=========================================
  Hits         1062    1062              
- Misses       1310    1324      +14
Impacted Files Coverage Δ
promgen/signals.py 27.45% <0%> (-2.34%) ⬇️
promgen/views.py 43.75% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d2f3c5...7e0c14f. Read the comment docs.

@kfdm kfdm merged commit d466d4e into line:master Jan 24, 2019
@kfdm kfdm deleted the subscribe-notice branch January 24, 2019 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants