Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Use django-filters for api filtering #126

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Conversation

kfdm
Copy link
Collaborator

@kfdm kfdm commented Feb 21, 2019

  • Filter shard by name /api/shard?name=
  • Filter service by name, shard /api/service?name=&shard=
  • Filter project by name, shard, service /api/project?name=&shard=&service=

@codecov-io
Copy link

codecov-io commented Feb 21, 2019

Codecov Report

Merging #126 into master will increase coverage by 0.33%.
The diff coverage is 93.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   46.34%   46.68%   +0.33%     
==========================================
  Files          39       40       +1     
  Lines        2451     2455       +4     
==========================================
+ Hits         1136     1146      +10     
+ Misses       1315     1309       -6
Impacted Files Coverage Δ
promgen/settings.py 0% <ø> (ø) ⬆️
promgen/filters.py 100% <100%> (ø)
promgen/rest.py 61.11% <100%> (+2.28%) ⬆️
promgen/serializers.py 94.44% <86.66%> (+10.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e13739...5893507. Read the comment docs.

@kfdm kfdm changed the title Filters [IMPROVEMENT] Use django-filters for api filtering Mar 29, 2019
@kfdm kfdm requested a review from m-tkg March 29, 2019 07:30
@kfdm kfdm marked this pull request as ready for review March 29, 2019 07:30
@kfdm kfdm merged commit 4bb287c into line:master Apr 1, 2019
@kfdm kfdm deleted the filters branch April 1, 2019 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants