Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial work on removing v1 rules #148

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Initial work on removing v1 rules #148

merged 1 commit into from
Jul 3, 2019

Conversation

kfdm
Copy link
Collaborator

@kfdm kfdm commented May 29, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented May 29, 2019

Codecov Report

Merging #148 into master will decrease coverage by 0.86%.
The diff coverage is 23.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
- Coverage   47.18%   46.32%   -0.87%     
==========================================
  Files          42       42              
  Lines        2473     2407      -66     
==========================================
- Hits         1167     1115      -52     
+ Misses       1306     1292      -14
Impacted Files Coverage Δ
promgen/tasks.py 39.72% <0%> (ø) ⬆️
promgen/rest.py 65.3% <0%> (+4.19%) ⬆️
promgen/views.py 48.63% <20%> (+0.27%) ⬆️
promgen/prometheus.py 60.26% <66.66%> (-7.05%) ⬇️
promgen/templatetags/promgen.py 39.17% <0%> (-2.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ecff37...75237d4. Read the comment docs.

@kfdm kfdm requested review from Asuforce and m-tkg July 3, 2019 03:01
@kfdm kfdm marked this pull request as ready for review July 3, 2019 03:01
Copy link
Member

@Asuforce Asuforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kfdm kfdm merged commit 4a3af99 into line:master Jul 3, 2019
@kfdm kfdm deleted the remove-rule-v1 branch July 3, 2019 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants