Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rule import #165

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Fix rule import #165

merged 1 commit into from
Aug 14, 2019

Conversation

kfdm
Copy link
Collaborator

@kfdm kfdm commented Aug 14, 2019

- Add test cases for each scenario
- Refactor settings for add_user_permissions
- Ensure rule is registered with correct ContentType

@codecov-io
Copy link

codecov-io commented Aug 14, 2019

Codecov Report

Merging #165 into master will increase coverage by 0.66%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
+ Coverage   46.41%   47.07%   +0.66%     
==========================================
  Files          43       42       -1     
  Lines        2424     2411      -13     
==========================================
+ Hits         1125     1135      +10     
+ Misses       1299     1276      -23
Impacted Files Coverage Δ
promgen/views.py 50.43% <100%> (+1.8%) ⬆️
promgen/migrations/0010_app_label_migration.py
promgen/prometheus.py 60.92% <0%> (+0.66%) ⬆️
promgen/templatetags/promgen.py 40.2% <0%> (+1.03%) ⬆️
promgen/forms.py 94.38% <0%> (+5.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba629d7...c166882. Read the comment docs.

- Add test cases for each scenario
- Refactor settings for add_user_permissions
- Ensure rule is registered with correct ContentType
@kfdm kfdm requested a review from m-tkg August 14, 2019 03:06
@kfdm kfdm marked this pull request as ready for review August 14, 2019 03:14
@kfdm kfdm merged commit 083da60 into line:master Aug 14, 2019
@kfdm kfdm deleted the fix-rule-import branch August 14, 2019 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants