Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Refactor macro for common use case #168

Merged
merged 1 commit into from
Aug 15, 2019
Merged

Conversation

kfdm
Copy link
Collaborator

@kfdm kfdm commented Aug 15, 2019

Merge after #167

@kfdm kfdm requested a review from m-tkg August 15, 2019 03:02
@codecov-io
Copy link

codecov-io commented Aug 15, 2019

Codecov Report

Merging #168 into master will increase coverage by 0.02%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
+ Coverage   47.05%   47.07%   +0.02%     
==========================================
  Files          43       43              
  Lines        2425     2428       +3     
==========================================
+ Hits         1141     1143       +2     
- Misses       1284     1285       +1
Impacted Files Coverage Δ
promgen/prometheus.py 60.92% <ø> (ø) ⬆️
promgen/views.py 49.85% <0%> (ø) ⬆️
promgen/templatetags/promgen.py 41% <75%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c680b79...7aa968c. Read the comment docs.

@kfdm kfdm merged commit ea5cf7d into line:master Aug 15, 2019
@kfdm kfdm deleted the refactor-macro branch August 15, 2019 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants