Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hostname validation #181

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Fix hostname validation #181

merged 1 commit into from
Oct 2, 2019

Conversation

kfdm
Copy link
Collaborator

@kfdm kfdm commented Oct 2, 2019

  • Move validation into forms.HostForm
  • Minor refactoring of views.HostRegister

- Move validation into forms.HostForm
- Minor refactoring of views.HostRegister
@kfdm kfdm requested a review from m-tkg October 2, 2019 01:33
@codecov-io
Copy link

Codecov Report

Merging #181 into master will increase coverage by 0.15%.
The diff coverage is 76.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
+ Coverage   47.11%   47.26%   +0.15%     
==========================================
  Files          43       43              
  Lines        2424     2435      +11     
==========================================
+ Hits         1142     1151       +9     
- Misses       1282     1284       +2
Impacted Files Coverage Δ
promgen/views.py 50% <62.5%> (-0.15%) ⬇️
promgen/forms.py 93.13% <84.61%> (-1.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e5b7d7...23c549d. Read the comment docs.

@kfdm kfdm merged commit 8e726c6 into line:master Oct 2, 2019
@kfdm kfdm deleted the host-verify branch October 2, 2019 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants