Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cleanup #243

Merged
merged 4 commits into from
Feb 28, 2020
Merged

Test cleanup #243

merged 4 commits into from
Feb 28, 2020

Conversation

kfdm
Copy link
Collaborator

@kfdm kfdm commented Feb 25, 2020

No description provided.

@kfdm kfdm force-pushed the test-cleanup branch 2 times, most recently from 5480038 to 666950d Compare February 26, 2020 03:38
@codecov-io
Copy link

codecov-io commented Feb 26, 2020

Codecov Report

Merging #243 into master will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
+ Coverage   46.42%   46.66%   +0.23%     
==========================================
  Files          53       51       -2     
  Lines        2632     2578      -54     
==========================================
- Hits         1222     1203      -19     
+ Misses       1410     1375      -35
Impacted Files Coverage Δ
promgen/tasks.py 43.37% <0%> (-2.09%) ⬇️
promgen/notification/__init__.py
promgen/migrations/0016_alertlabel.py
promgen/models.py 28.76% <0%> (+0.04%) ⬆️
promgen/views.py 48.68% <0%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c25cf6a...451e2ef. Read the comment docs.

@kfdm kfdm requested a review from shokada February 28, 2020 02:15
@kfdm kfdm marked this pull request as ready for review February 28, 2020 02:15
@kfdm kfdm merged commit 9a2b465 into line:master Feb 28, 2020
@kfdm kfdm deleted the test-cleanup branch February 28, 2020 02:51
kfdm added a commit to kfdm/promgen that referenced this pull request Mar 11, 2020
The test classes were refactored in line#243 but this instance was missed
kfdm added a commit that referenced this pull request Mar 11, 2020
The test classes were refactored in #243 but this instance was missed
kfdm added a commit that referenced this pull request Mar 11, 2020
The test classes were refactored in #243 but this instance was missed

(cherry picked from commit e6de74b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants