Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Update requirements #431

Merged
merged 3 commits into from
Jul 31, 2023
Merged

[INTERNAL] Update requirements #431

merged 3 commits into from
Jul 31, 2023

Conversation

kfdm
Copy link
Collaborator

@kfdm kfdm commented Jul 28, 2023

No description provided.

kfdm added 3 commits July 28, 2023 16:51
We previously had a lot of old pinned versions in a number of places.
Going forward, we want to relax the pins in setup.cfg and we can
periodically do a `make compile` to update our docker/requirements.txt.
Since we have a default secret key generated, we no longer have to
specify a dummy value here.
By having a default value here, it makes it more difficult if you want
to run a one-off container for testing. Removing the default makes it
easier if one wants to run /bin/sh or any other command. The remaining
entries are just shortcuts for celery/gunicorn.
Copy link
Contributor

@vincent-olivert-riera vincent-olivert-riera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kfdm kfdm marked this pull request as ready for review July 31, 2023 02:42
@kfdm kfdm requested a review from a team as a code owner July 31, 2023 02:42
@kfdm kfdm merged commit 49dda83 into line:master Jul 31, 2023
3 checks passed
@kfdm kfdm deleted the update-requirements branch July 31, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants