[IMPROVEMENT] Rewrite copyto in plain javascript #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfdm
force-pushed
the
javascript-copyto
branch
from
1a8f94e
to
d332c1c
Compare
vincent-olivert-riera
previously approved these changes
Feb 19, 2024
promgen/static/js/promgen.js
Outdated
| document.querySelectorAll("[data-copyto]").forEach(srcElement => { | ||
| srcElement.style.cursor = "pointer"; | ||
| srcElement.addEventListener("click", e => { | ||
| var dstElement = document.querySelector(srcElement.dataset.copyto); |
There was a problem hiding this comment.
I always recommend using const by default, unless the variable needs to be reassigned, in which case I recommend using let. In my opinion var should always be avoided.
That is my opinion on JS best practices, but you may have others, hence this comment is optional.
There was a problem hiding this comment.
Sounds reasonable. I think I just don't have enough awareness of javascript best practices since I don't write it as much. Changed to const but just force-pushed for the single, small change.
There was a problem hiding this comment.
Re-approved 👍
As we work towards removing our dependence on jQuery, we want to rewrite our copyto helper in plain javascript
kfdm
force-pushed
the
javascript-copyto
branch
from
d332c1c
to
ad40c9a
Compare
vincent-olivert-riera
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we work towards removing our dependence on jQuery, we want to rewrite our copyto helper in plain javascript