Refactor notifications queue #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
=========================================
- Coverage 47.26% 47.16% -0.1%
=========================================
Files 76 77 +1
Lines 2503 2508 +5
=========================================
Hits 1183 1183
- Misses 1320 1325 +5
Continue to review full report at Codecov.
|
* Refactors NotificationBase to be concerned only with sending the message. Notifications now have no knowledge of the celery queue or Project/Service models * Alert model handles expanding alert json based on Project/Service model but has no knowledge about about configured sender plugins * Incoming alerts are saved to the database for auditing purposes and queued to be processed * Processing alerts expands the alert data, and de-duplicates sender targets before queuing to be sent
kfdm
force-pushed
the
alert-queue-refactor
branch
from
088689d
to
85c7ea8
Compare
kfdm
added a commit
to kfdm/promgen
that referenced
this pull request
Sep 25, 2018
Combined with the new notifier queue in line#94 add a prune command so we can avoid having our database grow too much
kfdm
added a commit
to kfdm/promgen
that referenced
this pull request
Sep 25, 2018
Combined with the new notifier queue in line#94 add a prune command so we can avoid having our database grow too much
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors NotificationBase to be concerned only with sending the
message. Notifications now have no knowledge of the celery queue
or Project/Service models
Alert model handles expanding alert json based on Project/Service
model but has no knowledge about about configured sender plugins
Incoming alerts are saved to the database for auditing purposes and
queued to be processed
Processing alerts expands the alert data, and de-duplicates sender
targets before queuing to be sent