-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include unifiednlp too #4
Comments
Valid point, I'll add it. I'm not sure about the second, I think it should work also without signature spoofing. |
Based on my understanding, the second one corresponds to com.google.android.gms (https://f-droid.org/en/packages/com.google.android.gms/) whereas the first one corresponds to org.microg.nlp (https://f-droid.org/en/packages/org.microg.nlp/). Hence, the 2nd one is the commonly used one which needs spoofing. There's also com.google.android.maps (the one in this repo) which corresponds to the legacy maps api I guess. So that's also a spoofing version. However, I don't see it included in the patch. Is it even used ? |
AFAIK the signature spoofing is needed to spoof microG's GmsCore as authentic for the Play Services client library included in the APKs. On the other hand, the location services just check whether:
From its point of view, com.google.android.gms is a name like another, nothing here should require the signature spoofing. Also note that, if you just need UnifiedNlp and you're building your own ROM, the first one should be the best choice, as no signature spoofing is required, you're not using a Google package name and you're still able to install Gapps along UnifiedNlp (if needed). |
I was thinking of taking a crack at it. What would be the required permissions in permissions xml file ? Based on your privapp-permissions-com.google.android.gms.xml, this would need android.permission.INSTALL_LOCATION_PROVIDER. However, based on the f-droid package description, it also needs the following permissions:
Do I need all of these ? Based on this comment, it looks like ACCESS_COARSE_LOCATION and ACCESS_FINE_LOCATION are needed, but the package itself doesn't mention ACCESS_FINE_LOCATION. Also not sure about the other permissions. |
I think the sole purpose of this project should be to include those MicroG APKs that need signature spoofing. |
This repo only serves the lineageos4microg builds. If you want to include any other app for your own builds, feel free to fork. |
…updates Automate updates
I see that this repo doesn't include unifiednlp separately. It includes the other microg stuff, which acts like a superset, but from my understanding, it should be possible to use unifiednlp on its own in less intrusive ways. I would like to use this repo for some builds, and test the following options in increasing order of intrusiveness:
The text was updated successfully, but these errors were encountered: