Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include unifiednlp too #4

Closed
pgera opened this issue Mar 21, 2018 · 6 comments
Closed

include unifiednlp too #4

pgera opened this issue Mar 21, 2018 · 6 comments

Comments

@pgera
Copy link

pgera commented Mar 21, 2018

I see that this repo doesn't include unifiednlp separately. It includes the other microg stuff, which acts like a superset, but from my understanding, it should be possible to use unifiednlp on its own in less intrusive ways. I would like to use this repo for some builds, and test the following options in increasing order of intrusiveness:

  • unifiednlp as a network provider. Doesn't need signature spoofing (this is called gapps mode confusingly in the original repo). config_locationProviderPackageNames should have org.microg.nlp and the app should be a system app from my reading.
  • unifiednlp no gapps mode. This needs signature spoofing. This is still useful on its own without using full microg for getting navigation apps to work.
  • entire microg. This is already done right now.
@corna
Copy link
Contributor

corna commented Mar 21, 2018

Valid point, I'll add it.

I'm not sure about the second, I think it should work also without signature spoofing.

@pgera
Copy link
Author

pgera commented Mar 21, 2018

Based on my understanding, the second one corresponds to com.google.android.gms (https://f-droid.org/en/packages/com.google.android.gms/) whereas the first one corresponds to org.microg.nlp (https://f-droid.org/en/packages/org.microg.nlp/). Hence, the 2nd one is the commonly used one which needs spoofing. There's also com.google.android.maps (the one in this repo) which corresponds to the legacy maps api I guess. So that's also a spoofing version. However, I don't see it included in the patch. Is it even used ?

@corna
Copy link
Contributor

corna commented Mar 21, 2018

AFAIK the signature spoofing is needed to spoof microG's GmsCore as authentic for the Play Services client library included in the APKs.

On the other hand, the location services just check whether:

From its point of view, com.google.android.gms is a name like another, nothing here should require the signature spoofing.

Also note that, if you just need UnifiedNlp and you're building your own ROM, the first one should be the best choice, as no signature spoofing is required, you're not using a Google package name and you're still able to install Gapps along UnifiedNlp (if needed).

@pgera
Copy link
Author

pgera commented Oct 9, 2018

I was thinking of taking a crack at it. What would be the required permissions in permissions xml file ? Based on your privapp-permissions-com.google.android.gms.xml, this would need android.permission.INSTALL_LOCATION_PROVIDER. However, based on the f-droid package description, it also needs the following permissions:

android.permission.INSTALL_LOCATION_PROVIDER
android.permission.ACCESS_COARSE_UPDATES
android.permission.ACCESS_COARSE_LOCATION
android.permission.RECEIVE_BOOT_COMPLETED
org.microg.permission.FORCE_COARSE_LOCATION
com.android.settings.INJECT_SETTINGS 

Do I need all of these ? Based on this comment, it looks like ACCESS_COARSE_LOCATION and ACCESS_FINE_LOCATION are needed, but the package itself doesn't mention ACCESS_FINE_LOCATION. Also not sure about the other permissions.

@ghost
Copy link

ghost commented Jan 14, 2021

I think the sole purpose of this project should be to include those MicroG APKs that need signature spoofing.
All other modifications should be up to the LineageOS developers.
Keep it simple.

@bananer
Copy link
Contributor

bananer commented Oct 28, 2021

This repo only serves the lineageos4microg builds. If you want to include any other app for your own builds, feel free to fork.

@bananer bananer closed this as completed Oct 28, 2021
pipoprods pushed a commit to pipoprods/android_prebuilts_prebuiltapks that referenced this issue Mar 7, 2022
dic1911 pushed a commit to dic1911/android_prebuilts_prebuiltapks that referenced this issue Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants