Replace From<Rgba8> for PremulColor with From<PremulRgba8>
#113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having the `From<Rgba8>` was unintentional and should have been `From<PremulRgba8>`. A trait impl can't be deprecated with an attribute, so just note it in the doc comment.
|
Alternatively, we could keep the If we merge this one, then I'll file an issue for the 0.3.0 milestone to remind us to remove the code. |
nicoburns
approved these changes
Dec 22, 2024
|
We could just remove this and make the next release |
|
I don't want to do a 0.3.0 yet ... at the least, I'd have to deal with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the
From<Rgba8>was unintentional and should have beenFrom<PremulRgba8>.A trait impl can't be deprecated with an attribute, so just note it in the doc comment.