Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement (Premul)Rgba8::from_u32 and from_u8_array #135

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

tomcur
Copy link
Member

@tomcur tomcur commented Jan 18, 2025

Closes #73.

The conversions from the packed u32 are easy to get wrong when implemented manually.

(On the other hand, these methods are also easy to use wrong.)

Closes linebender#73.

The conversions from the packed u32 are easy to get wrong when
implemented manually.

(On the other hand, these methods are also easy to use wrong.)
Copy link
Contributor

@raphlinus raphlinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! It's pretty cool that big-endian is tested in CI.

@tomcur tomcur added this pull request to the merge queue Jan 18, 2025
Merged via the queue into linebender:main with commit 2f4652e Jan 18, 2025
16 checks passed
@tomcur tomcur deleted the mirroring-from branch January 18, 2025 19:36
@tomcur
Copy link
Member Author

tomcur commented Jan 18, 2025

It's pretty cool that big-endian is tested in CI.

No kidding. to_u32 went through all three from_{be,le,ne}_bytes variants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

from_u32 on Rgba8 and PremulRgba8
2 participants