Allow focus changes from Update #1960
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, to UpdateCtx Signed-off-by: Christoph <xarvix@web.de>
|
What's the status of this? I don't see anything wrong with it, but was it discussed somewhere? |
|
I have reservations about this. It's possible that it's okay, but when events are triggered during update the interactions are complex. I think for the time being I would prefer to handle this by dispatching a command; it isn't elegant but it is easier to understand the control flow. |
I think the genesis is in this zulip thread. |
|
What's the status of this PR? @xarvic do you think we should still move forward with this? If we should move forward, then please rebase on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the methods needed to change focus to
UpdateCtx.