Convert relative links to absolute in readme #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the relative links will break on symlinked versions of the readme, eg. in the `./druid` directory.
jneem
reviewed
Oct 6, 2021
README.md
Outdated
| @@ -300,15 +300,15 @@ active and friendly community. | |||
| [Runebender]: https://github.com/linebender/runebender | |||
| [the examples folder]: ./druid/examples | |||
|
Thanks for the patch! It looks like there's one more link that would benefit from the same treatment. |
Update links for screenshots and another one I missed
|
Sure thing :) I've updated that one as well as the links when you click on the screenshots |
|
Awesome, thanks! Gotta wait for the CI to be happy, and then I'll merge it. |
jneem
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug, where some of the links in the readme would break, if accessed from the symlinked version in the ./druid subdirectory on Github.