Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OptionFormatter TextBox Formatter #2193

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

meettitan
Copy link

@meettitan meettitan commented May 28, 2022

Adds a simple TextBox Formatter for optional values. inspired by ParseFormatter. Useful for integers to map empty strings to Option::None.

Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really sorry for letting this wait so long.

Please rebase on master so we can pass the CI without clippy errors. After we pass the CI I will take a deeper look.

@@ -12,6 +12,7 @@ You can find its changes [documented below](#070---2021-01-01).

### Added

- OptionFormatter TextBox Formatter ([#2193] by [@meettitan])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately the links don't get automatically generated. Please define both [#2193] and [@meettitan] at the bottom of the file.

@xStrom xStrom added the S-waiting-on-author waits for changes from the submitter label Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author waits for changes from the submitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants