-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ViewportHeader widget #2312
Open
xarvic
wants to merge
14
commits into
linebender:master
Choose a base branch
from
xarvic:new_overlay
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please rebase on Additionally, please give a short description of what the purpose of the |
- update example
@xStrom i edited the description of the ViewportHeader widget and also improved the example. |
xarvic
added
S-needs-review
waits for review
and removed
S-waiting-on-author
waits for changes from the submitter
labels
Jan 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functionality based on the
ViewContextChanged
lifecycle event, which provides widgets with information about the viewport.The
ViewportHeader
widget has a header child and a content child and moves the header over the content if this helps to keep the header inside the viewport. This way the header widget sticks to the border of the viewport. For an example this is useful if you have multiple large widgets in a scroll view and always want to know which element you are currently looking at.ScrollToView
request also work, since theViewportHeader
widget intercept and transforms the requests.The Align widget gains the ability to only consider its visible part for aligning its child.