Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L10n example and performance improvements #2313

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

JasperDeSutter
Copy link

Adds an example showing how to use fluent to translate text, including a more advanced plural selection.
Fixes a couple unneeded String clones in the localization implementation by using a Cow, and prevents the bidi markers from being written by fluent so we don't need to remove them.

@xStrom xStrom added the S-waiting-on-author waits for changes from the submitter label Jan 12, 2023
@xStrom
Copy link
Member

xStrom commented Jan 12, 2023

I'll try to take a look at this soon. Meanwhile please rebase on master to fix the clippy errors so we can pass the CI.

@JasperDeSutter JasperDeSutter force-pushed the l10n-performance branch 2 times, most recently from 6c196ee to b8881af Compare January 14, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author waits for changes from the submitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants