-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic image widget #557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay just a first pass, but this looks reasonable; I think it makes sense for there to be an image widget available, and this is a good start.
If we do merge this we will want to add documentation to all pub
lic items.
Thanks for the PR!
Thank you for tackling the various |
@futurepaul I had loads of changes to svg to allow embedded png/bmp images but it did not scale well enough for my use case. and trying to work out how it should work was hard. many of the references i looked at had different implementations. so i have not tidied it all up as i thought i would try to land this and see how much demand there was for the svg stuff, I am more than happy to look at the svg stuff if its useful. |
d892679
to
8b4b47a
Compare
cff6224
to
293f750
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay a couple more notes here, but looks pretty close to me!
293f750
to
7cf41c6
Compare
e1c6a25
to
e9b98ed
Compare
9295e08
to
bea9efb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay a few more things I've spotted and a few comment fixes, we're getting close tho!
2806066
to
41b8ac4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay a few more doc fixes 😁
1381139
to
2bec29c
Compare
I have set this so maintainers can push the branch on my fork. I'm very dyslexic as you have probably noticed and have no issue with others pushing a typo fix etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for your patience!
I was using this to make plots but it did not scale well.
I am trying a different approach but have been a bit side tracked but made some progress and would like to finish that too.
But this example may be useful to others/(me in the future) so I thought would push it up.
Most of the code is behind feature flags.