Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add control_box method to BezPath #306

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Add control_box method to BezPath #306

merged 2 commits into from
Oct 3, 2023

Conversation

dfrg
Copy link
Contributor

@dfrg dfrg commented Oct 3, 2023

This adds a method to BezPath that computes a conservative bounding box only taking control points into account.

dfrg added 2 commits October 3, 2023 14:00
This adds a method to `BezPath` that computes a conservative bounding box only taking control points into account.
Copy link
Contributor

@raphlinus raphlinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd slightly prefer returning Option<Rect>, but Chad points out that this is more consistent with the existing bounding_box method.

@dfrg dfrg merged commit ad67725 into linebender:main Oct 3, 2023
14 checks passed
@dfrg dfrg deleted the control-box branch October 3, 2023 18:12
anthrotype added a commit to googlefonts/fontations that referenced this pull request Oct 4, 2023
anthrotype added a commit to googlefonts/fontations that referenced this pull request Oct 4, 2023
dfrg pushed a commit to googlefonts/fontations that referenced this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants