Additional tests and fixes for BezPath::reverse_subpaths #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial PR for this was missing a large batch of test cases. Adding these revealed that subpath reversal did not accurately capture degenerate contours (move only or move + close) which we'd like to retain in glyphs. This adds the tests and updates the code to pass them (ref: https://github.com/googlefonts/fontations/blob/145a2ae269f30a3fbc217ef9cddb18a8a80a8f5b/write-fonts/src/pens.rs#L562C1-L564C104)
anthrotype
approved these changes
Oct 4, 2023
| } | ||
|
|
||
| #[test] | ||
| fn test_reverse_single_point_closed() { |
There was a problem hiding this comment.
this test and the one immediately preceding are exactly the same as test_reverse_move_only_path_offset_validity and test_reverse_move_close_path_offset_validity, are they not?
There was a problem hiding this comment.
They appear to be, but I just copied them all directly from our tests in write-fonts :) I'll remove the redundant ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial PR for this was missing a large batch of test cases. Adding these revealed that subpath reversal did not accurately capture degenerate contours (move only or move + close) which we'd like to retain in glyphs.
This adds the tests and updates the code to pass them (ref: https://github.com/googlefonts/fontations/blob/145a2ae269f30a3fbc217ef9cddb18a8a80a8f5b/write-fonts/src/pens.rs#L562C1-L564C104)