Add failing test for quadbez panic and add fix. #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this PR, the `ParamCurveNearest::nearest` method can panic for `QuadBez` with certain input. This PR adds a test to avoid the panic.
|
I ran the changed code through the |
raphlinus
approved these changes
Oct 12, 2023
| @@ -1,3 +1,5 @@ | |||
| .vscode | |||
There was a problem hiding this comment.
Was this intentional? I think it's ok but am wondering if it accidentally got picked up.
There was a problem hiding this comment.
I was seeing it in my git status and thought I'd add it to .gitignore so that I don't accidentally include it with git add -A which I use from time to time. I don't think we'll want to include vscode stuff in kurbo in the future but if we do we can always remove it from .gitignore :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the
ParamCurveNearest::nearestmethod can panic forQuadBezwith certain input. This PR adds a test to avoid the panic.Closes #315