Replace panic with error return in BezPath::from_svg
#329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is failing on clippy lints: |
raphlinus
approved these changes
Jan 16, 2024
DJMcNab
added a commit
to DJMcNab/kurbo
that referenced
this pull request
Feb 14, 2024
linebender#329 was a breaking change To avoid a similar situation in future, mark the offending enum `#[non_exhaustive]`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #303 (comment)
BezPath::from_svgdoes not handle case when SVG path does not start with initial point. This PR makes theBezPath::from_svgreturn an error for this case.