Reduce number of operations in Triangle::circumscribed_circle
#390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphlinus
reviewed
Oct 30, 2024
tomcur
force-pushed
the
simpler-circumcircle
branch
from
1e2b348 to
cb23325
Compare
raphlinus
approved these changes
Nov 25, 2024
|
(I think you need to rebase/merge main to trigger the formatting CI, possibly because something changed on main here, Github UI is not very helpful here...) |
(On top of PR linebender#387, as I'm removing a method here that is still used until that PR is merged. I'll keep this in draft until then.) This is based on the simplified form for Cartesian coordinates in https://en.wikipedia.org/w/index.php?title=Circumcircle&oldid=1247179617#Cartesian_coordinates_2 Also adds a test to check the circle radius' sign is equal to the sign of the triangle's area.
tomcur
force-pushed
the
simpler-circumcircle
branch
from
e721bac to
dd9af02
Compare
(Yep, that triggered it. Thanks!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the simplified form for Cartesian coordinates in https://en.wikipedia.org/w/index.php?title=Circumcircle&oldid=1247179617#Cartesian_coordinates_2
Also adds a test to check the circle radius' sign is equal to the sign of the triangle's area.