Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Update typos to 1.26.1 #392

Merged
merged 1 commit into from
Oct 23, 2024
Merged

ci: Update typos to 1.26.1 #392

merged 1 commit into from
Oct 23, 2024

Conversation

waywardmonkeys
Copy link
Contributor

No description provided.

@waywardmonkeys
Copy link
Contributor Author

Since we can't yet update the stable Rust version in CI, we can at least get this edit in place.

@waywardmonkeys waywardmonkeys added this pull request to the merge queue Oct 23, 2024
Merged via the queue into linebender:main with commit 5719d80 Oct 23, 2024
15 checks passed
@waywardmonkeys waywardmonkeys deleted the ci-update-typos branch October 23, 2024 17:36
@DJMcNab
Copy link
Member

DJMcNab commented Oct 24, 2024

Since we can't yet update the stable Rust version in CI, we can at least get this edit in place.

This is a very oblique statement. Why not?

@waywardmonkeys
Copy link
Contributor Author

The benches use a cfg(nightly) and should be converted to criterion or something. Could just do an unexpected_cfgs thing but would rather eventually do the real fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Philipp-M Philipp-M Philipp-M approved these changes

@xStrom xStrom Awaiting requested review from xStrom

@DJMcNab DJMcNab Awaiting requested review from DJMcNab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waywardmonkeys @DJMcNab @Philipp-M