Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make public methods in norad::write private? #227

Closed
madig opened this issue Dec 29, 2021 · 2 comments
Closed

Make public methods in norad::write private? #227

madig opened this issue Dec 29, 2021 · 2 comments

Comments

@madig
Copy link
Collaborator

madig commented Dec 29, 2021

Specifically write_plist_value_to_file, write_xml_to_file and write_quote_style public. I think they are used only internally? @chrissimpkins
@madig madig changed the title Make public methods in norad::write private Make public methods in norad::write private? Dec 29, 2021
@madig
Copy link
Collaborator Author

madig commented Dec 29, 2021

Closed by #228

@madig madig closed this as completed Dec 29, 2021
@chrissimpkins
Copy link
Collaborator

Font::load and Font::save_with_options are the only public R/W methods that ufofmt uses in the impl. I'll check if any of these methods are used in tests. We'll find a way around it if so. Thanks for the ping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@madig @chrissimpkins