Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove write_plist_value_to_file #228

Merged
merged 1 commit into from
Dec 29, 2021
Merged

Remove write_plist_value_to_file #228

merged 1 commit into from
Dec 29, 2021

Conversation

madig
Copy link
Collaborator

@madig madig commented Dec 29, 2021

And take the remaining code private. The newest plist crate implements serde::Serialize for values.

@madig
Remove write_plist_value_to_file
cee6548 
And take the remaining code private.
@github-actions
Copy link

🗜 Bloat check ⚖️

Comparing 900afa6 against d4af02b

target old size new size difference
target/release/examples/load_save 1.9 MB 1.9 MB 2.19 KB (0.11%)
target/debug/examples/load_save 8.56 MB 8.59 MB 29.89 KB (0.34%)

cmyr
cmyr approved these changes Dec 29, 2021
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@madig madig merged commit fb6e931 into master Dec 29, 2021
@madig madig deleted the simplify-write branch December 29, 2021 22:01
@madig madig mentioned this pull request Dec 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madig @cmyr