Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take some load/save methods private #229

Merged
merged 1 commit into from
Jan 1, 2022
Merged

Take some load/save methods private #229

merged 1 commit into from
Jan 1, 2022

Conversation

madig
Copy link
Collaborator

@madig madig commented Dec 29, 2021

They should probably not be used in normal operation.

Closes #225

@madig madig force-pushed the privatize-some-loadsavers branch from 7e5234d to a887f9d Compare December 30, 2021 11:25
@github-actions
Copy link

🗜 Bloat check ⚖️

Comparing ee31461 against 16ada43

target old size new size difference
target/release/examples/load_save 1.9 MB 1.9 MB -280 Bytes (-0.01%)
target/debug/examples/load_save 8.58 MB 8.58 MB -232 Bytes (-0.00%)

@linebender linebender deleted a comment from github-actions bot Dec 30, 2021
cmyr
cmyr approved these changes Dec 31, 2021
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@madig madig merged commit 4b23a52 into master Jan 1, 2022
@madig madig deleted the privatize-some-loadsavers branch January 1, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr approved these changes

@chrissimpkins chrissimpkins chrissimpkins left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose only Font and Glyph saving and loading methods
3 participants
@madig @cmyr @chrissimpkins