Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Identifier hashing into Self's Impl #59

Merged
merged 2 commits into from
Nov 16, 2020
Merged

Move Identifier hashing into Self's Impl #59

merged 2 commits into from
Nov 16, 2020

Conversation

madig
Copy link
Collaborator

@madig madig commented Nov 12, 2020

No description provided.

cmyr
cmyr approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! hash_self feels a bit funky as a method name to me, and I think just hash should be fine?

@madig
Copy link
Collaborator Author

madig commented Nov 16, 2020

Wait, I'm not done yet! Haven't gotten around to the actual splitting out part.

@cmyr
Copy link
Member

cmyr commented Nov 16, 2020

hahaha but this is such a nice little PR, so easy to merge!

@madig madig changed the title Split OutlineBuilder out of GlyphBuilder Move Identifier hashing into Self's Impl Nov 16, 2020
@madig madig marked this pull request as ready for review November 16, 2020 23:21
@madig madig merged commit 8b54774 into master Nov 16, 2020
@madig madig deleted the outline-builder branch November 16, 2020 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madig @cmyr