Update kurbo and svg dependencies, fix a clippy warning. #562
+15
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratmice
force-pushed
the
update_svg_kurbo
branch
3 times, most recently
from
920b70b to
6b73e28
Compare
Svg had a future incompatibility warning, upgrade to fix that. Clippy noticed that MultiSource is !Send, !Sync. So replace Arc<Mutex<MultiSource> with Rc<RefCell<_>>. Ditto for piet-coregraphics.
ratmice
force-pushed
the
update_svg_kurbo
branch
from
6b73e28 to
9e127c0
Compare
jneem
approved these changes
Dec 26, 2023
|
Yeah, perhaps it is better if I drop the version bumps to avoid the breaking changes? |
|
I don't think it's so bad to have the version bump, just as long as we're aware that it needs one. I think it makes sense to have a version of piet that's compatible with the latest version of kurbo, after all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates to the latest kurbo, I could have a version which is compatible with both piet and vello...
font_kit::sources::MultiSourceis!Send !Sync, So replaceArc<Mutex<MultiSource>withRc<RefCell<_>>.Not sure if this last bit is a wanted change, or if it'd be preferred to just silence the warning, or ignore it entirely?