Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove r8 permutations of shaders #756

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Remove r8 permutations of shaders #756

merged 1 commit into from
Nov 30, 2024

Conversation

waywardmonkeys
Copy link
Collaborator

These aren't used and it was discussed in #755 to remove them.

Fixes #755.

@waywardmonkeys
Copy link
Collaborator Author

By not having the r8 permutations of the shaders, the shaders.rs is 160k smaller!

DJMcNab
DJMcNab approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formalising approval from #755

@waywardmonkeys
Remove r8 permutations of shaders
aad5217 
These aren't used and it was discussed in linebender#755 to remove them.

Fixes linebender#755.
@waywardmonkeys waywardmonkeys added this pull request to the merge queue Nov 30, 2024
Merged via the queue into linebender:main with commit 1e48628 Nov 30, 2024
17 checks passed
@waywardmonkeys waywardmonkeys deleted the remove-r8-permutation branch November 30, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fate / status of r8 ifdef in shaders
2 participants
@waywardmonkeys @DJMcNab