Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat some docs to work around clippy::doc_overindented_list_items #811

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

waywardmonkeys
Copy link
Collaborator

This is a new lint in nightly.

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I'd already submitted these...

@@ -460,18 +461,18 @@ impl<'a> PathEncoder<'a> {
/// The algorithm is as follows:
///
/// a) If a GPU thread is processing a regular segment (i.e. `SUBPATH_END_BIT` is 0), it
/// outputs the offset curves for the segment. If the segment is immediately followed by
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that making this a proper nested sublist is probably better style, i.e. replace a) with either 1. or -.

Certainly the existing indentation strongly suggests it's intended to be a nested sublist

@@ -14,18 +14,19 @@ pub struct Style {
/// Encodes the stroke and fill style parameters. This field is split into two 16-bit
/// parts:
///
/// - `flags: u16` - encodes fill vs stroke, even-odd vs non-zero fill mode for fills and cap
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have strong feelings about this one, although I'm not sure that the new formatting is better. I can see reasonable arguments for making it an HTML table, or just expecting the lint here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants