Fix panic at Option::unwrap in App::accessibility #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoburns
approved these changes
Oct 19, 2023
DJMcNab
reviewed
Oct 19, 2023
| @@ -199,6 +199,7 @@ where | |||
|
|
|||
| pub fn accessibility(&mut self) -> TreeUpdate { | |||
| let mut update = TreeUpdate::default(); | |||
| self.ensure_root(); | |||
There was a problem hiding this comment.
A small thought (not relevant to this PR) - should Glazier be handling this instead?
There was a problem hiding this comment.
Good question, I'm not deep enough in the codebase currently to provide good input (especially in glazier), maybe someone else should investigate (still not really in the best situation to code right now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #134